Fix code span wrongly identified as code block #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close mity#201. What happens in mity#201 is that MD4C identifies the first "```" as the start of a fenced code block. Threfore it renders "aaa" and " ```" as code block lines, then it automatically closes the fenced code block at EOF. DETAILS Commonmark spec 0.30 about fenced code blocks. A fenced code block begins with a code fence, preceded by up to three spaces of indentation.[1] A fenced code block may interrupt a paragraph, and does not require a blank line either before or after.[2] - [1] https://github.com/commonmark/commonmark-spec/blob/d5706b9553d4665ca730524323d484880440186c/spec.txt#L1940 - [2] https://github.com/commonmark/commonmark-spec/blob/d5706b9553d4665ca730524323d484880440186c/spec.txt#L1969
|
Race condition :-) Fixed few minutes ago myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #201.
What happens in #201 is that MD4C identifies the first "```" as the start of a fenced code block.
Threfore it renders "aaa" and " ```" as code block lines, then it
automatically closes the fenced code block at EOF.
DETAILS
Commonmark spec 0.30 about fenced code blocks.
A fenced code block begins with a code fence, preceded by up to three spaces of indentation.[1]
A fenced code block may interrupt a paragraph, and does not require a blank line either before or after.[2]