Midi receive message chunking fix proposal #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per #122 This takes care of the chunking issue for Sysex messages on a slow connection (Network Session 1). Testing this I found it quite easy to replicate with quite a large variation in chunk sizes although never less than 3 bytes. Gorges iPad Midi monitor shows the same behaviour but manages to finally cough up the final sysex message.
|
This seems to not be building. I can't look at it in detail at the moment. If you could make sure the framework project builds with a fresh clone of your branch, and if not, fix the problem, that would be great. |
|
Just posting to let you know that I haven't forgotten about this. Will try to get to it soon. |
|
No problem, at your leisure
|
ghost
mentioned this pull request
|
Ended up being superseded by #200. Thank you so much for the contribution! |
|
Hey Andrew,
Thanks for getting the “proper” SysEx fix into the main branch.
An FYI you might be interested in: A customer wanted to be able to process Midi from a DAW for dense orchestral compositions via Swift Mac App to a Swift iPad App using 700ish port / channels. It looked like 10K Midi messages a second would need to be handled with enough left on top for the iPad App to do its thing, I went no way, I talked to my hardware designer and synth aficionado friend and he said no way, you need some hardware. So I decided I would have to get all the numbers and prove it could not be done and say sorry … time passes … and its working. Just tested on a composition he produced for Dr Who that has peaks of 20 to 30K messages a second, with the iPad Air 2 perf of 40% of cpu in a highly tuned but still Swift debug build.
Amazing, that’s quite library you have there.
Thanks again
Clay
… On Aug 22, 2017, at 10:01 AM, Andrew Madsen ***@***.***> wrote:
Closed #130 <#130>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABwkhNGXB499YBb2m0TCWAbS7dmx1iX7ks5sawlugaJpZM4HcePV>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #122
This takes care of the chunking issue for Sysex messages on a slow
connection (Network Session 1). Testing this I found it quite easy to
replicate with quite a large variation in chunk sizes although never
less than 3 bytes. Gorges iPad Midi monitor shows the same behaviour
but manages to finally cough up the final sysex message.