[WIP] redisによるsequencerを追加 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/spec_helper.rb
Outdated
| @@ -24,3 +24,5 @@ | |||
| config.before(:each) do | |||
| end | |||
| end | |||
|
|
|||
|
良さそうに思えた！（変な空白ラインの差分以外は） |
nktks
reviewed
Nov 10, 2017
README.rdoc
Outdated
| seq_type: redis | ||
| connection: redis_sequencer # <-- redis sequencer name | ||
| shards: | ||
| - connection: redis_shard_1 |
nktks
reviewed
Nov 13, 2017
| @seq_shard = SeqShard.new(seq) | ||
| seq = (@options[:seq] || @config[:seq]) | ||
| if seq | ||
| if seq.values.size > 0 && seq.values.first["seq_type"] == "mysql" |
There was a problem hiding this comment.
seq_type無指定の時はmysqlのようですので、
その場合も@seq_shardにセットする必要がありそうです。
There was a problem hiding this comment.
https://github.com/drecom/activerecord-turntable/pull/28/files#diff-aa73b66f1c9647a7824bb29f250b55e8R49
とかみても、
seqはそもそもconfig/turntable.ymlではhash想定？なので、
seq["seq_type"]を評価する必要ありそうです。
nktks
reviewed
Nov 13, 2017
| seq = (@options[:seq] || @config[:seq]) | ||
| if seq | ||
| if seq.values.size > 0 && seq.values.first["seq_type"] == "mysql" | ||
| @seq_shard = SeqShard.new(seq.values.first) |
There was a problem hiding this comment.
をみると、hashを期待しているようなので、
seqをわたせばよさそうです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redisを利用したsequencerを追加します
修正点/特記事項