Support ruby3 #18
Merged
Support ruby3 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed CI GitHub Actions insted of travis mixigroup#15 - Not need others
- Update README
winebarrel
force-pushed
the
support-ruby3
branch
from
7cfe0c9 to
f61df56
Compare
winebarrel
force-pushed
the
support-ruby3
branch
from
f61df56 to
5a55213
Compare
winebarrel
force-pushed
the
support-ruby3
branch
from
6fa4dc6 to
6f47bf2
Compare
winebarrel
force-pushed
the
support-ruby3
branch
from
897d3cf to
773ea63
Compare
hirocaster
reviewed
Apr 2, 2024
| @@ -364,21 +364,6 @@ def get_or_read(store, key) | |||
| it_behaves_like "cache store example", one_cache_store | |||
| end | |||
| end | |||
|
|
|||
| context "ActiveSupport :dalli_store in Dalli" do | |||
There was a problem hiding this comment.
Why remove these specs?
There was a problem hiding this comment.
This test was removed in 5b0bdaa, probably because dalli_store was removed from dalli 3.0.
cf. https://stackoverflow.com/a/76655389
An error occurred while loading ./spec/double_write_cache_stores/client_spec.rb.
Failure/Error: read_and_write_store = ActiveSupport::Cache.lookup_store :dalli_store, "localhost:11211"
RuntimeError:
Could not find cache store adapter for dalli_store (cannot load such file -- active_support/cache/dalli_store)
# ./spec/double_write_cache_stores/client_spec.rb:369:in `block (3 levels) in <top (required)>'
# ./spec/double_write_cache_stores/client_spec.rb:368:in `block (2 levels) in <top (required)>'
# ./spec/double_write_cache_stores/client_spec.rb:349:in `block in <top (required)>'
# ./spec/double_write_cache_stores/client_spec.rb:11:in `<top (required)>'
# ------------------
# --- Caused by: ---
# LoadError:
# cannot load such file -- active_support/cache/dalli_store
# ./spec/double_write_cache_stores/client_spec.rb:369:in `block (3 levels) in <top (required)>'
Finished in 0.00002 seconds (files took 0.70444 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
There was a problem hiding this comment.
Ok, that sounds good.
Could you update Support backend cache store in README.md ?
There was a problem hiding this comment.
Fixed README 🙏 b7255a5
winebarrel
commented
Apr 2, 2024
| @@ -3,4 +3,4 @@ | |||
| $LOAD_PATH.unshift File.expand_path("../../lib", __FILE__) | |||
| require "double_write_cache_stores" | |||
| require "dalli" | |||
| require "dalli/cas/client" | |||
| require "dalli/client" | |||
There was a problem hiding this comment.
This is a fix for the warning below:
You can remove
require 'dalli/cas/client'as this code has been rolled into the standard 'dalli/client'.
winebarrel
force-pushed
the
support-ruby3
branch
2 times, most recently
from
31b04d3 to
773ea63
Compare
|
@hirocaster Could you please check PR? 🙇 |
hirocaster
requested changes
Apr 10, 2024
| @@ -364,21 +364,6 @@ def get_or_read(store, key) | |||
| it_behaves_like "cache store example", one_cache_store | |||
| end | |||
| end | |||
|
|
|||
| context "ActiveSupport :dalli_store in Dalli" do | |||
There was a problem hiding this comment.
Ok, that sounds good.
Could you update Support backend cache store in README.md ?
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports Ruby 3.0 based on https://github.com/matsubara0507/double_write_cache_stores/tree/support-ruby3 .
Also made fixes for RuboCop. ea4306d
@hirocaster @matsubara0507 Could you please review?