Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip empty table rows. Fixes domchristie#276. #311

Closed

Conversation

michbart
Copy link

Current implementation skips empty table rows, but it shouldn't as the specification says, that there can be empty row. This PR fixes #276, I didn't add TABLE intentionally as it was in #277.

Example 1:

<table>
  <thead>
    <tr>
      <th>Header</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td></td>
    </tr>
    <tr>
      <td>Cell</td>
    </tr>
  </tbody>
</table>

Should be

| Header |
| --- |
|  |
| Cell |

Example 2:

<table>
  <thead>
    <tr>
      <th></th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td>Cell</td>
    </tr>
  </tbody>
</table>

Should be

|  |
| --- |
| Cell |

@domchristie
Copy link
Collaborator

Thanks for this. I have used this idea as part of #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TABLE/THEAD/TBODY/TR as element to not consider blank
2 participants