Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli flags 2.4 #567

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Update cli flags 2.4 #567

merged 2 commits into from
Jun 18, 2023

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Jun 4, 2023

manual PR for mixxxdj/mixxx#11474 along with some housekeeping.

@Swiftb0y Swiftb0y force-pushed the update-cli-flags-2.4 branch from ca63191 to fc16924 Compare June 5, 2023 10:28
JoergAtGithub
JoergAtGithub approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does everybody agrees to merge this?

@Swiftb0y Swiftb0y force-pushed the update-cli-flags-2.4 branch from fc16924 to be3a3a3 Compare June 18, 2023 15:21
@Swiftb0y
Copy link
Member Author

thank you, rebased and force-pushed to fix CI.

@Swiftb0y
Copy link
Member Author

yey, all green.

@JoergAtGithub
Copy link
Member

Thank you!

@JoergAtGithub JoergAtGithub merged commit e4e281d into mixxxdj:2.4 Jun 18, 2023
@Swiftb0y
Copy link
Member Author

Thank you.

@Swiftb0y Swiftb0y deleted the update-cli-flags-2.4 branch June 19, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoergAtGithub JoergAtGithub JoergAtGithub approved these changes

@ronso0 ronso0 ronso0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiftb0y @JoergAtGithub @ronso0