Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ci upgrade python #716

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fix/ci upgrade python #716

merged 3 commits into from
Jan 17, 2025

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Jan 15, 2025

Usual maintenance as 3.7 got dropped in the CI runners/setup. Lets see.

@daschuer
Copy link
Member

Can we also pin the Ubuntu version, to prevent us from such an unstable regression in future?

@Swiftb0y
Copy link
Member Author

We can... but I'm unsure if there is an advantage. Sure CI won't break silently but upgrading (which we'll have to do inevitably at some point) will be harder because because so much changes at once...

@Swiftb0y Swiftb0y force-pushed the fix/ci-upgrade-python branch from 076def7 to 83eb388 Compare January 15, 2025 18:03
# HTML files shat should be inserted after the pages created by sphinx.
# HTML files that should be inserted after the pages created by sphinx.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

favorite typo so far 🤣

Copy link
Member Author

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for review

@daschuer
Copy link
Member

We can... but I'm unsure if there is an advantage. Sure CI won't break silently but upgrading (which we'll have to do inevitably at some point) will be harder because because so much changes at once.

ubuntu-latest is no rolling release. Is just points to one of the workflow runners. When GitHub decide to relink it, we have the same bunch of changes as if we do the change manually. The difference is we can control the date and it will not happen during a release process or at some other bad timing.

IMHO pinning the python version does make no sense if we do not pin the runner that has that version. I don't see any disadvantages.

@Swiftb0y
Copy link
Member Author

@Holzhaus, thoughts?

@Holzhaus
Copy link
Member

I don't have a strong opinion on pinning the runner os, but I also don't see how this relates to the pinned Python version.

Python 3.7 has been end-of-life for over year now, so it comes as no surprise it has been removed: https://devguide.python.org/versions/#python-release-cycle

I suggest we merge this now. The runner discussion can continue on Zulip but should not block this PR IMHO.

@Holzhaus Holzhaus merged commit 4ea91a4 into mixxxdj:2.5 Jan 17, 2025
9 checks passed
@Swiftb0y Swiftb0y deleted the fix/ci-upgrade-python branch January 18, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants