-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ci upgrade python #716
Conversation
Can we also pin the Ubuntu version, to prevent us from such an unstable regression in future? |
We can... but I'm unsure if there is an advantage. Sure CI won't break silently but upgrading (which we'll have to do inevitably at some point) will be harder because because so much changes at once... |
076def7
to
83eb388
Compare
# HTML files shat should be inserted after the pages created by sphinx. | ||
# HTML files that should be inserted after the pages created by sphinx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
favorite typo so far 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready for review
ubuntu-latest is no rolling release. Is just points to one of the workflow runners. When GitHub decide to relink it, we have the same bunch of changes as if we do the change manually. The difference is we can control the date and it will not happen during a release process or at some other bad timing. IMHO pinning the python version does make no sense if we do not pin the runner that has that version. I don't see any disadvantages. |
@Holzhaus, thoughts? |
I don't have a strong opinion on pinning the runner os, but I also don't see how this relates to the pinned Python version. Python 3.7 has been end-of-life for over year now, so it comes as no surprise it has been removed: https://devguide.python.org/versions/#python-release-cycle I suggest we merge this now. The runner discussion can continue on Zulip but should not block this PR IMHO. |
Usual maintenance as
3.7
got dropped in the CI runners/setup. Lets see.