Merge pull request #11242 from ronso0/effect-param-swap-noop

EffectSlot::swapParameters: ignore no-op, e.g. after aborted drag (drop on itself)
mixxxdj · Feb 3, 2023 · 3f6876f · 3f6876f
2 parents 4cb5d94 + f67662a
commit 3f6876f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/effects/effectslot.cpp b/src/effects/effectslot.cpp
@@ -463,6 +463,9 @@ void EffectSlot::showParameter(EffectParameterPointer pParameter) {
 }
 
 void EffectSlot::swapParameters(EffectParameterType type, int index1, int index2) {
+    if (index1 == index2) {
+        return;
+    }
     VERIFY_OR_DEBUG_ASSERT(m_loadedParameters[type].size() > index1) {
         return;
     }