Qt5Keychain: Map missing configuration to the first one. #10901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for a configuration error in Ubuntu 22.4 where Qt5Keychain is build with the configuration "None" In case a either matching configuration is found or "Release" it is picked instead of just the first.
|
Here is a failing workflow run with the 2.3 branch build on the Ubuntu 22.4 runner that verifies that merging this PR to the 2.3 branch is required: https://github.com/daschuer/mixxx/actions/runs/3065678208/jobs/4950019247 |
|
I have found the root cause: |
|
Here is the root cause fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for a configuration error in Ubuntu 22.4 where Qt5Keychain is build with the configuration "None" In case a either matching configuration is found or "Release" it is picked instead of just the first.
This is a hack around the root cause which I have not yet understand.
I think we need to debug cmTarget.cxx oc cmake to find out.
However changing the cmake version has no effect.
This is a PR against 2.3 to make sure it keeps building on Unbutu 22.4
A CI run for main that shows that the build is fixed can be found here:
https://github.com/daschuer/mixxx/actions/runs/3056487033
Once this is merged I will take care to merge it into main as well.