Tracks view: keep current item visible when the view shrinks vertically #11273
Conversation
ronso0
force-pushed
the
tracks-keep-selected-item-in-view
branch
from
e48b754 to
34c3079
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
ronso0
force-pushed
the
tracks-keep-selected-item-in-view
branch
from
34c3079 to
038cbb0
Compare
|
Code looks is much better understandable now! |
|
The pre-commit failure is unrelated. |
src/widget/wtracktableview.cpp
Outdated
| } | ||
|
|
||
| QModelIndex currIndex = currentIndex(); | ||
| int rHeight = rowHeight(0); |
There was a problem hiding this comment.
This can be moved closer to usage.
I think it can become
'rowHeight(currRow)`
to make it work even if we have different row heights one day.
There was a problem hiding this comment.
It's used right below.
I looked at the Qt sources and noticed !currIndex.isValid() can be replaced with currRow < 0 || rowHeight(currRow()) = 0
src/widget/wtracktableview.cpp
Outdated
| // y-pos of the top edge, negative value means above viewport boundary | ||
| int posInView = rowViewportPosition(currRow); | ||
| // Check if the row is visible. | ||
| // Note: don't use viewport()->height() because that may already have changed (??) |
src/widget/wtracktableview.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| // TODO(xxx) When resizing, the top row is static, at least on Linux. |
There was a problem hiding this comment.
I think this is correct and the TODO can be removed.
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
JoergAtGithub
removed
the
stale
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
This still works good. Thank you. |
Just a small helper to fix an issue I had on my list for a long time:
if you toggle/expand a hidden/collapsed container (waveforms, effects, sampler) the track view shrinks which can push the track selection out of sight.
This commit makes sure it is pulled into view again if required.
Testing
Pick a track at the bottom of the view, and make sure there are some hidden skin regions to expand.
That track should reman visible both when showing a hidden region, as well as when manually (slowly) dragging the waveform splitter downwards.
Note: even though this handles the currentIndex (focused item, not the selection) this doesn't matter unless you use Ctrl + keys to move independent from the selection.