Init WOverview with a track, if it was already loaded before #11453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
reviewed
Apr 8, 2023
|
|
||
| // Connect the player's load and unload signals to the overview widget. | ||
| connect(pPlayer, &BaseTrackPlayer::newTrackLoaded, overviewWidget, &WOverview::slotTrackLoaded); | ||
| connect(pPlayer, &BaseTrackPlayer::loadingTrack, overviewWidget, &WOverview::slotLoadingTrack); | ||
|
|
||
| // just in case track already loaded | ||
| overviewWidget->slotLoadingTrack(pPlayer->getLoadedTrack(), TrackPointer()); | ||
| overviewWidget->slotTrackLoaded(pPlayer->getLoadedTrack()); |
There was a problem hiding this comment.
So the issue was that slotWaveformSummaryUpdated() was missing here?
There was a problem hiding this comment.
Yes., It was working in 2.3.3 because we use the stored track length and not the real length which is not read before slotTrackLoaded()
|
Works & LGTM, thank you! |
ronso0
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the WOverview::Init with a track. This fixes an issue that the waveform overview is empty after skin change, because of missing the real track signals during loading