Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/Export Serato Loops with index offset 8 #11534

Merged
merged 4 commits into from
May 4, 2023
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented May 4, 2023

Also skip import in case of existing Mixxx cues. This fixes #11530

daschuer added 3 commits May 4, 2023 08:04
Export and Import Serato Loop cues with a fixed offset off 8. Skip all cue entries that are not usable in Serato. Do not shift cues.
This keeps the cues identifiable by there index resp. the position in the grid. This may match the position in a track or a position schema of the user.
@daschuer daschuer added this to the 2.3.5 milestone May 4, 2023
src/test/seratotagstest.cpp Outdated Show resolved Hide resolved
src/track/serato/tags.cpp Outdated Show resolved Hide resolved
Co-authored-by: Swiftb0y <[email protected]>
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the import algorithms could use a refactoring in general, but I won't put that burden on you in this PR.
LGTM.

@Swiftb0y Swiftb0y merged commit aa9e57e into mixxxdj:2.3 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants