Improve debug output for some file system operations #11783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
Aug 5, 2023
src/library/parsercsv.cpp
Outdated
| @@ -129,7 +133,7 @@ bool ParserCsv::writeCSVFile(const QString &file_str, BaseSqlTableModel* pPlayli | |||
| if (!file.open(QIODevice::WriteOnly | QIODevice::Text)) { | |||
| QMessageBox::warning(nullptr, | |||
| tr("Playlist Export Failed"), | |||
| tr("Could not create file") + " " + file_str); | |||
| tr("Could not create file") + " " + file_str + "\n" + file.errorString()); | |||
There was a problem hiding this comment.
This is possibly not localized and may look weird to inexperienced users. I think we should use the property-based API here and use the detailed text for this.
src/recording/recordingmanager.cpp
Outdated
| @@ -189,11 +189,14 @@ void RecordingManager::setRecordingDir() { | |||
| ConfigKey(RECORDING_PREF_KEY, "Directory"))); | |||
| // Note: the default ConfigKey for recordDir is set in DlgPrefRecord::DlgPrefRecord. | |||
|
|
|||
| if (!recordDir.exists()) { | |||
| if (recordDir.mkpath(recordDir.absolutePath())) { | |||
| if (recordDir.exists()) { | |||
src/recording/recordingmanager.cpp
Outdated
| if (!recordDir.exists()) { | ||
| if (recordDir.mkpath(recordDir.absolutePath())) { | ||
| if (recordDir.exists()) { | ||
| if (!recordDir.mkpath(recordDir.absolutePath())) { |
There was a problem hiding this comment.
I think the exclamation mark is wrong here.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to help finding the root cause of issue #11778