privat generated ui headers #12060
privat generated ui headers #12060
Conversation
daschuer
force-pushed
the
privat_generated
branch
from
7393be8 to
386781d
Compare
|
@acolombier Does this work for you? |
|
I'm currently away from the computer but I will test it as soon as I get back to it. Alternatively, I have managed to also remove that work around by using the forward declaration in case this change would have repercussions on other things. |
|
It looks like that did the trick, thanks! Edit: |
src/qml/qmlapplication.cpp
Outdated
| @@ -5,6 +5,7 @@ | |||
| #include "control/controlsortfiltermodel.h" | |||
| #include "controllers/controllermanager.h" | |||
| #include "moc_qmlapplication.cpp" | |||
| #include "preferences/dialog/dlgpreferences.h" | |||
There was a problem hiding this comment.
This line seems to cause issue since it means that the QML library (in my feature, I have splitted mixxx-lib in two) will also need preferences/dialog/ui_dlgpreferencesdlg.h. I belive however that I could take your change in, plus the one I've made to initialize the QML signletons as part of the CoreService instead of as part of the QML application, which then removes the need for DlgPreferences in this file
There was a problem hiding this comment.
I believe this line can actually be removed.
This hides implementation details from the mixxx-qml-lib
daschuer
force-pushed
the
privat_generated
branch
from
386781d to
3a0603a
Compare
|
Ready for merge, the Coveralls failure seems to be unrelated. |
|
Done |
|
Code LGTM! All review comments are addressed and I tested it as part of #12139 on Win11. Thank you! |
This makes the ui_dlgpreferencesdlg.h private by moving the instantiation of the DlgPreferences to CoreServices.
This fixes one issue from #11407