Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preferences: apply changes from all pages when pressing Apply (like when pressing Okay) #12194

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Preferences: apply changes from all pages when pressing Apply (like when pressing Okay) #12194

merged 1 commit into from
Feb 11, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 19, 2023 •
edited
Loading

Currently it's very confusing that

  • pressing Apply + Cancel (apply pending changes on the current page, close, discard other changes)
    is not the same as
  • pressing Okay (apply pending changes in all pages, close)

One step further to fixing #7440

@github-actions github-actions bot added the ui label Oct 19, 2023
@github-actions GitHub Actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 28, 2024
daschuer
daschuer approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 6154c7a into mixxxdj:2.4 Feb 11, 2024
@ronso0 ronso0 deleted the pref-apply-okay branch February 11, 2024 12:37
@ronso0 ronso0 mentioned this pull request Feb 12, 2024
Merged
@ronso0 ronso0 mentioned this pull request Jul 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
gui preferences stale Stale issues that haven't been updated for a long time. usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer