Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: fix track relocation query #12462

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Library: fix track relocation query #12462

merged 2 commits into from
Dec 24, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 23, 2023

After all it was missing : that made the entire relocation fail.
Seems this was broken for years.

I'm surprised there's no error raised for no-op bindvalue().

mentioning Relink so I find this PR later on

@ronso0 ronso0 added this to the 2.4.0 milestone Dec 23, 2023
@ronso0 ronso0 added the bug label Dec 23, 2023
@ronso0
Copy link
Member Author

ronso0 commented Dec 24, 2023

@mixxxdj/developers This is quick fix and I'd appreciate if someone could take a look and press merge, for those millions of Mixxx users who will migrate to the new PCs they'll get for christmas ; )

Copy link
Member

@fwcd fwcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, should this target 2.4 (base branch is main currently)?

@ronso0 ronso0 changed the base branch from main to 2.4 December 24, 2023 19:11
@ronso0
Copy link
Member Author

ronso0 commented Dec 24, 2023

jup, correct, switched to 2.4

@fwcd fwcd merged commit c5079a5 into mixxxdj:2.4 Dec 24, 2023
12 checks passed
@ronso0 ronso0 deleted the lib-relocate-fix branch December 24, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants