Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-line delegate: fix bg color, Qt6 on Linux #12478

Merged
merged 1 commit into from
Jan 1, 2024
Merged

multi-line delegate: fix bg color, Qt6 on Linux #12478

merged 1 commit into from
Jan 1, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 29, 2023

Curiously, with Qt6 on Linux this line causes what it avoided with Qt5: white bars at the bottom of the comment editor.

Would be nice if anyone on Windows and macOS can compare main/this.

before:
Screenshot_2023-12-29_22-59-39

this:
Screenshot_2023-12-29_22-58-13

@ronso0 ronso0 added the QT6 label Dec 29, 2023
@ronso0 ronso0 added this to the 2.5.0 milestone Dec 29, 2023
@daschuer
Copy link
Member

How about a version guard instead of a comment?
2.5 will be a qt6 release, but we will keep Qt5 compatibility for comparison.

@ronso0
Copy link
Member Author

ronso0 commented Dec 30, 2023

Yes, I will add the version guard, just wanted to evaluate where it works or not.
(setting to draft until I cleaned it up)

@ronso0 ronso0 marked this pull request as draft December 30, 2023 12:34
@ronso0 ronso0 force-pushed the lib-comment-editor-fix branch from 6b91dba to b413337 Compare December 31, 2023 13:19
@ronso0
Copy link
Member Author

ronso0 commented Dec 31, 2023

Yes, I will add the version guard, just wanted to evaluate where it works or not. (setting to draft until I cleaned it up)

Done.

@ronso0 ronso0 marked this pull request as ready for review December 31, 2023 14:40
daschuer
daschuer approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 17fd47b into mixxxdj:main Jan 1, 2024
12 checks passed
@ronso0 ronso0 deleted the lib-comment-editor-fix branch January 1, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library QT6
Projects
None yet
Milestone
2.5-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer