Playlist feature: add 'Shuffle playlist' sidebar action #12498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
shuffle-playlist
branch
from
4f5d3c7 to
6950df4
Compare
daschuer
reviewed
Jan 2, 2024
| } else { | ||
| // Create a temp model so we don't need to select the playlist | ||
| // in the persistent model in order to shuffle it | ||
| QScopedPointer<PlaylistTableModel> pPlaylistTableModel( |
There was a problem hiding this comment.
Did you consider to use unique_ptr and make_unique to get around the literal new()? You may also update other occurrences.
There was a problem hiding this comment.
Tbh I didn't think about it in this case. Ime my PRs sit for too long when I optimize too much en passant.
However, there are 9 occurences of this pattern in the playlist features and I can of course change them to use unique_ptr
There was a problem hiding this comment.
Ups, I did not notice how that there so many occurrences. Thank you very much for fixing them all.
ronso0
force-pushed
the
shuffle-playlist
branch
from
89e2f09 to
d567642
Compare
|
Ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6988