Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add QML interceptor to auto reload on file change #12795

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

acolombier
Copy link
Member

Currently, when working on the QML interface, if you want to hot reload that last one, you need to trigger a file change on res/qml/main.qml as it is the only file watched (e.g touch res/qml/main.qml). This makes the dev experience on the QML interface not very friendly.
This small change extends the QML app file watcher to dynamically "learn" file that are actively used in the interface such as QML component or SVG assets and watches them for hot-reload on change

@github-actions github-actions bot added the build label Feb 12, 2024
@ronso0 ronso0 added qml and removed build labels Feb 12, 2024
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very straightforward and easy to understand implementation. wdyt @Holzhaus?

Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

src/qml/qmlautoreload.cpp Outdated Show resolved Hide resolved
@Holzhaus Holzhaus merged commit d7a769b into mixxxdj:main Feb 17, 2024
13 checks passed
@Holzhaus
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants