fixes around cratetablemodel, remove tracks + don't allow pasting tracks into locked playlists/crates or History #12926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
tracklists_shortkeys
branch
from
059d46f to
a5f6c16
Compare
ronso0
force-pushed
the
tracklists_shortkeys
branch
from
a5f6c16 to
0cf83ef
Compare
avoids hitting DEBUG_ASSERT when removing tracks from a locked crate
ronso0
force-pushed
the
tracklists_shortkeys
branch
from
0cf83ef to
c3f1c7e
Compare
|
thanks, @ronso0 ! merged into my PR. |
|
Please also merge #12927 then, I can take care of merging to main. |
|
12927 merged to 2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12927
= the first two commits are fixes for 2.4
the third commit prevents pasting into locked tracksets