Revert to raster level meters in LateNight and Tango to fix severe GUI lag on macOS #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendering SVG level meters caused the whole GUI to become severely unresponsive on older Macs: https://bugs.launchpad.net/mixxx/+bug/1759433
Rendering SVGs for the level meters makes the GUI severely laggy on old Macs: https://bugs.launchpad.net/mixxx/+bug/1759433
|
I just tested with 250% scaling on my 3840 x 2160 screen with GNU/Linux and the meters still look good to me. I don't notice any blurriness. |
Be-ing
changed the title
ronso0
requested changes
Apr 1, 2018
res/skins/Tango/vumeter_floating.xml
Outdated
| <PathVu>graphics/vumeter_floating_over.svg</PathVu> | ||
| <PathBack>graphics/vumeter_floating.svg</PathBack> | ||
| <PathVu>skin:/graphics/vumeter_floating_over.png</PathVu> | ||
| <PathBack>skin:/graphics/vumeter_floating.</PathBack> |
|
... the rest LGTM |
|
I just noticed the Aux mute/play button icons in LateNight is reverted. |
|
FYI the SVG files are still in the Git repository. I just rendered them to PNG. |
|
I double checked this on the Macbook Air that I am borrowing and it works. 🎉 |
Please open another PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering SVGs for the meters causes the whole GUI to become severely laggy on older Macs:
https://bugs.launchpad.net/mixxx/+bug/1759433