Fix Mac build on case sensitive filesystems #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugs.launchpad.net/mixxx/+bug/1911064 Fix suggested by @Be-ing changes to lowercase to match the CMake targets instead of the other way around, so everything is copied to `mixxx.app` (lowercase) but the app still ends up with the correct case once packaged, so this seems simpler.
|
Thanks. I tested the build with macOS 10.13 on a case insensitive filesystem and it still works. |
This was referenced Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/mixxx/+bug/1911064
Fix suggested by @Be-ing changes to lowercase to match the CMake
targets instead of the other way around, so everything is copied to
mixxx.app(lowercase) but the app still ends up with the correctcase once packaged, so this seems simpler.