Update controller mapping for Behringer DDM4000 mixer #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug #671277 is related to the bug that I fixed by throttling. |
Swiftb0y
reviewed
Nov 28, 2021
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
|
This issue should not be labeled stale. |
uklotzde
removed
the
stale
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
No objection from my side. Please do not mark this PR as stale. |
uklotzde
removed
the
stale
The stale marker was added by a GitHub action. @Swiftb0y Merge? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains
nullinstead of empty strings for intentionally missing valuesParameterComponentthat is able to send correct output values for effect parametersEnumEncodercomponentThe bug was really annoying and hard to detect: on startup, only a part of the mixer LEDs had the correct state. Some were on, but others were off unexpectedly. After a few hours of debugging, it turned out that the problem is the processing speed of the hardware mixer. When too many MIDI messages arrive in a short time, only a part of them is processed. My solution is a configurable throttling logic that delays component initialization. Users may disable the throttling or change the delay.
The
ParameterComponentis required to send proper output values for effect parameters. Some of them have unusual values ranges, e.g. flanger speed[32..0,5]in a non-linear manner. Theoutput()function of theEncodercomponent is not prepared for this, it just multiplies this value with 127 and sends the result to the controller. TheParameterComponentuses the parameter (range:[0..1]) instead of the value, so the MIDI value is correct.