Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pref > Library: add link to manual > settings files info #4367

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 7, 2021

Now, the directory and related info can be accessed from one place, and most support responses regarding log files, configs, mappings, database file etc. can be boiled down to
"Open the preferences, go to the Library page and scroll to the bottom"

image

@github-actions github-actions bot added the ui label Oct 7, 2021
@daschuer
Copy link
Member

daschuer commented Oct 7, 2021

Nice.
It is a pity, that you are not able to discover it intuitively.
Did you consider to put it on its own root element?
Other ideas? About box? I am unsure.

However this works, and this is a good start IMHO. Thank you.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do the others think?

@ronso0
Copy link
Member Author

ronso0 commented Oct 7, 2021

Yeah, discoverability can be improved.
The preferences sidebar is already crammed IMO, I'd rather not add another item.
The About dialog is also not an appropriate place as it should remain compact, plus I wouldn't expect that info there.
Maybe add an item to the Help menu which opens separate dialog?

@daschuer
Copy link
Member

daschuer commented Oct 7, 2021

Yes, that will work hopefully better. I had a look to other applications:

  • Eclipse "Installation details" button in the about box
  • Firefox "Help" > "Info for .."
  • SmartGit "Information" Tab in the about box
  • LibreOffice Exta Preferences node

So we are in good companion whatever we decide.

@ronso0
Copy link
Member Author

ronso0 commented Oct 7, 2021

so for now we can merge this? it's just adding the link, the rest is already there.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 9, 2021

I think the Help menu would be a better place.

@ronso0
Copy link
Member Author

ronso0 commented Oct 9, 2021

To clarify:
this PR just adds the link to the manual.

Moving the entire section to another place will not happen in this PR.

Merge?

@Be-ing
Copy link
Contributor

Be-ing commented Oct 10, 2021

Eh, I'm not sure we should add even more text here; it's already quite wordy. I think it would be better to remove this whole section from the preferences and add a link to the Help menu.

@ronso0
Copy link
Member Author

ronso0 commented Oct 10, 2021

Those are currently three lines of text. Adding a link adds value now.

Moving the entire block to the Help menu and formatting the dialog is out of scope here and will happen in another PR.

@Be-ing
Copy link
Contributor

Be-ing commented Oct 10, 2021

Three lines of text is probably more than most users read already.

@Swiftb0y
Copy link
Member

Please just merge this. The fact that we're already 10 messages deep into a discussion on a PR this trivial makes no sense. This is bikeshedding at its best. The work has been done and we only need to press a single button to merge this. If instead we start arguing about marginally better approaches, we'll get nowhere, this won't get merged, contributors will stop contributing.

@ronso0
Copy link
Member Author

ronso0 commented Oct 11, 2021

I will not merge myself if there are objections, no matter if I consider them valid or not, no matter how ridiculous small the PR.
If there's a majority to merge just do it.

@Be-ing Be-ing merged commit fd8c925 into mixxxdj:main Oct 11, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Oct 11, 2021

I'm not sure that adding more text to a wall of text is a great idea but 🤷

@ronso0 ronso0 deleted the pref-settings-files-link branch October 11, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants