MC7000: Fix code style issue in pad buttons handler for 2.3 #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linter doesn't like the empty branches, therefore we remove them and add a comment detailing which modes are not implemented yet.
This was referenced May 12, 2022
fwcd
changed the title
|
Hm, the CI failure looks unrelated |
Swiftb0y
approved these changes
May 12, 2022
|
Now that this PR has been merged, please rebase the two PRs that depended on this onto 2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a code style issue in the MC7000 mapping that caused the pre-commit hook to fail on the 2.3 branch, namely a bunch of empty if-branches that are replaced with a comment detailing which modes are to be implemented.
More style issues (like
const/let) will be fixed in #4754, these aren't backwards compatible though and therefore in a separate PR.