Code

Verify the "first sound" #4773

Code

Merged

Swiftb0y merged 30 commits intomixxxdj:mainmixxxdj/mixxx:mainfrom daschuer:offset_detectdaschuer/mixxx:offset_detectCopy head branch name to clipboardDec 13, 2022

+229-118

Commits

Commits on May 28, 2022

• Verify the first sound and issue a warning in mixxx.log

  daschuer

  committed
  81f817a

  Copy full SHA for 81f817a

Commits on May 29, 2022

• Use kSilenceThreshold directly and add a coment that it must not be changed

  daschuer

  committed
  416746f

  Copy full SHA for 416746f

• Use SINT as Length parameter of Analyzer::processSamples()

  daschuer

  committed
  b299836

  Copy full SHA for b299836

• Extract static functions to find the first and the last sound

  daschuer

  committed
  3708324

  Copy full SHA for 3708324

Commits on May 30, 2022

• Move verifyFirstSound to the AnalyzerSilence class

  daschuer

  committed
  2ba9fe3

  Copy full SHA for 2ba9fe3

Commits on May 31, 2022

• Initalize nTrackSampleDataLength

  daschuer

  committed
  dd4342a

  Copy full SHA for dd4342a

Commits on Jun 5, 2022

• Move writing the mixxx.log entries out of AnalyzerSilence::verifyFirstSound()

  daschuer

  committed
  9111c7b

  Copy full SHA for 9111c7b

• Rename function to findFirstSoundInChunk()/findLasttSoundInChunk()

  daschuer

  committed
  837e879

  Copy full SHA for 837e879

• Refactor silence detections that the last sound is processed backwards

  daschuer

  committed
  d410c06

  Copy full SHA for d410c06

• Check return value of findFirstSoundInChunk() explicit

  daschuer

  committed
  d342d6c

  Copy full SHA for d342d6c

• Fix comment for findLastSoundInChunk()

  daschuer

  committed
  b94f788

  Copy full SHA for b94f788

Commits on Sep 5, 2022

• Explain why the uncoditinal verifyFirstSound() should be replaced

  daschuer

  committed
  2a9fbca

  Copy full SHA for 2a9fbca

• Restore TODO

  daschuer

  committed
  407dc21

  Copy full SHA for 407dc21

• reduce nesting

  daschuer

  committed
  828b6db

  Copy full SHA for 828b6db

Commits on Sep 6, 2022

• Use kNumSoundFrameToVerify and explain why two frames are sufficient

  daschuer

  committed
  43faef4

  Copy full SHA for 43faef4

• Merge remote-tracking branch 'upstream/main' into offset_detect

  daschuer

  committed
  4cfb776

  Copy full SHA for 4cfb776

Commits on Sep 7, 2022

• Apply std::span refactoring

  Show description for d993c03
  

  daschuer

  and

  Swiftb0y

  committed
  d993c03

  Copy full SHA for d993c03

• AnalyzerGain: Removed unused member variable

  daschuer

  committed
  eb0339f

  Copy full SHA for eb0339f

• More SINT in analyzers

  daschuer

  committed
  438f8ea

  Copy full SHA for 438f8ea

Commits on Sep 8, 2022

• Merge remote-tracking branch 'upstream/main' into offset_detect

  daschuer

  committed
  969cddb

  Copy full SHA for 969cddb

Commits on Oct 28, 2022

• Merge remote-tracking branch 'upstream/main' into offset_detect

  daschuer

  committed
  af1cb4b

  Copy full SHA for af1cb4b

Commits on Dec 11, 2022

• fixup math

  Show description for c5317b0
  daschuer

  committed
  c5317b0

  Copy full SHA for c5317b0

• Rename AudibleSound to 60dBSound to emphasize that this cue point has a fixed threshold.

  daschuer

  committed
  4a3b059

  Copy full SHA for 4a3b059

• Avoid long lines in comments

  daschuer

  committed
  8012a2b

  Copy full SHA for 8012a2b

• Merge remote-tracking branch 'upstream/main' into offset_detect

  Show description for 6fcd9e3
  daschuer

  committed
  6fcd9e3

  Copy full SHA for 6fcd9e3

Commits on Dec 12, 2022

• Add line break after "requires"

  daschuer

  committed
  6844798

  Copy full SHA for 6844798

• Merge remote-tracking branch 'upstream/main' into offset_detect

  daschuer

  committed
  a8e80b0

  Copy full SHA for a8e80b0

Commits on Dec 13, 2022

• Added test AnalyzerSilenceTest,verifyFirstSound

  daschuer

  committed
  d937a08

  Copy full SHA for d937a08

• Added a comment about the temprary nature of thes first sound verification

  daschuer

  committed
  96ed941

  Copy full SHA for 96ed941

• findLastSoundInChunk() returns samples.size() if no sample is found

  daschuer

  committed
  9f99531

  Copy full SHA for 9f99531