Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fall back to searching the mirror when a mirror-index has been specified #150

Closed
wants to merge 1 commit into from

Conversation

thaljef
Copy link
Contributor

@thaljef thaljef commented May 4, 2012

I'm using cpanm with Pinto to install packages from a local repository. The repository can have multiple indexes, so the mirror-index option is a perfect fit. However, when I specify an explicit mirror-index, I do not want it to fall back to the repository's default index. I would argue that this should be the behavior whenever mirror-index is specified.

But I can imagine that some folks might argue the other way. So perhaps the fall back behavior could be disabled with a separate switch (it looks like --mirror-index already implies --mirror-only). Let me know if you would prefer that.

@miyagawa
Copy link
Owner

miyagawa commented May 4, 2012

This has been on my list for a long time and I agree that it is a
desired behavior.

Sent from my iPhone

On May 4, 2012, at 11:06 AM, Jeffrey Ryan Thalhammer
[email protected]
wrote:

I'm using cpanm with Pinto to install packages from a local repository. The repository can have multiple indexes, so the mirror-index option is a perfect fit. However, when I specify an explicit mirror-index, I do not want it to fall back to the repository's default index. I would argue that this should be the behavior whenever mirror-index is specified.

But I can imagine that some folks might argue the other way. So perhaps the fall back behavior could be disabled with a separate switch (it looks like --mirror-index already implies --mirror-only). Let me know if you would prefer that.

You can merge this Pull Request by running:

git pull https://github.com/thaljef/cpanminus master

Or you can view, comment on it, or merge it online at:

#150

-- Commit Summary --

  • Do not fall back to mirrors when a mirror-index has been specified.

-- File Changes --

M cpanm (6)
M lib/App/cpanminus/script.pm (6)

-- Patch Links --

https://github.com/miyagawa/cpanminus/pull/150.patch
https://github.com/miyagawa/cpanminus/pull/150.diff


Reply to this email directly or view it on GitHub:
#150

@miyagawa miyagawa closed this in 0745cdb May 11, 2012
miyagawa added a commit that referenced this pull request May 11, 2012
Changelog diff is:

diff --git a/Changes b/Changes
index cbe2ffb..e475125 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 See http://github.com/miyagawa/cpanminus/ for the latest development.

+1.5012 Fri May 11 05:47:56 CEST 2012
+   [Improvements]
+      - Change the behavior of --mirror-index so that it won't fallback to CPAN mirrors #150 (thaljef)
+      - Support v-strings in versions specified install [perl-carton/carton#48]
+
 1.5011 Thu Apr 12 18:57:06 JST 2012
    [Improvements]
       - Point default mirror to www.cpan.org #148
@miyagawa
Copy link
Owner

ok this broke Carton's layover update and multiple mirror support. Should put back in the old (or new) behavior with options.

miyagawa added a commit that referenced this pull request May 12, 2012
Changelog diff is:

diff --git a/Changes b/Changes
index e475125..bf6a4b7 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,9 @@
 See http://github.com/miyagawa/cpanminus/ for the latest development.

+1.5013 Sat May 12 06:15:44 EEST 2012
+   [Bug Fixes]
+      - Fixed --cascade-search to seach for missing modules, which was broken by #150
+
 1.5012 Fri May 11 05:47:56 CEST 2012
    [Improvements]
       - Change the behavior of --mirror-index so that it won't fallback to CPAN mirrors #150 (thaljef)
miyagawa added a commit that referenced this pull request Jun 13, 2012
Changelog diff is:

diff --git a/Changes b/Changes
index bf6a4b7..fa7e89c 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,11 @@
 See http://github.com/miyagawa/cpanminus/ for the latest development.

+1.5014 Tue Jun 12 18:27:02 PDT 2012
+   [Improvements]
+      - Make sure 'f' flag becomes the last for some tar versions (mst, aaronsw)
+      - Fixed warnings on perl 5.17+ (rjbs)
+      - Fix local::lib error message (berekuk)
+
 1.5013 Sat May 12 06:15:44 EEST 2012
    [Bug Fixes]
       - Fixed --cascade-search to seach for missing modules, which was broken by #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants