Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to specify config.yaml #30

Merged
merged 15 commits into from
Nov 4, 2020
Merged

add option to specify config.yaml #30

merged 15 commits into from
Nov 4, 2020

Conversation

mjavier2k
Copy link
Owner

@mjavier2k mjavier2k commented Nov 3, 2020 •
edited
Loading

  • Remove username and password command-line option (security)
  • Add option to specify username/password in a config file

Implements #25
Fixes #25

Co-Authored-By: Jordan Neufeld [email protected]

@mjavier2k mjavier2k requested a review from neufeldtech November 3, 2020 18:55
neufeldtech
neufeldtech reviewed Nov 3, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
neufeldtech
neufeldtech reviewed Nov 3, 2020
View reviewed changes
config.yaml.example Outdated Show resolved Hide resolved
mjavier2k and others added 4 commits November 3, 2020 16:00
@mjavier2k @neufeldtech
Update README.md
9bcd4ce 
Co-authored-by: Jordan Neufeld <[email protected]>
@mjavier2k @neufeldtech
Update cmd/solidfire-exporter/main.go
7e5bfa1 
Co-authored-by: Jordan Neufeld <[email protected]>
@mjavier2k @neufeldtech
Update cmd/solidfire-exporter/main.go
8d2ff6d 
Co-authored-by: Jordan Neufeld <[email protected]>
@mjavier2k @neufeldtech
Update config.yaml.example
5df1f84 
Co-authored-by: Jordan Neufeld <[email protected]>
@mjavier2k mjavier2k requested a review from neufeldtech November 3, 2020 22:08
neufeldtech
neufeldtech reviewed Nov 3, 2020
View reviewed changes
config.yaml.example Outdated Show resolved Hide resolved
@mjavier2k mjavier2k requested a review from neufeldtech November 4, 2020 03:15
neufeldtech
neufeldtech approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@neufeldtech neufeldtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 IT!

@mjavier2k mjavier2k merged commit f87f532 into master Nov 4, 2020
@mjavier2k mjavier2k deleted the add-configfile-option branch December 4, 2020 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neufeldtech neufeldtech neufeldtech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve security by removing password from commandline
2 participants
@mjavier2k @neufeldtech