Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: make calls to SF api in parallel #62

Merged
merged 3 commits into from
Apr 25, 2021
Merged

perf: make calls to SF api in parallel #62

merged 3 commits into from
Apr 25, 2021

Conversation

neufeldtech
Copy link
Collaborator

@neufeldtech neufeldtech commented Apr 25, 2021 •
edited
Loading

Makes calls to SF api in two different 'batches':

  • Batch 1 is the 'metadata' calls - ListNodes, and ListVolumes - we need this data to populate labels later on, so we need to make these first and wait for them to complete.
  • Batch 2 is the remainder of all of the 'metrics' calls - these all go at once

Resolves #41

@neufeldtech neufeldtech requested a review from mjavier2k as a code owner April 25, 2021 04:35
@neufeldtech
Copy link
Collaborator Author

It's recommended to view the diff of this pull request with the 'ignore whitespace' feature: https://github.com/mjavier2k/solidfire-exporter/pull/62/files?diff=split&w=1

@neufeldtech neufeldtech merged commit 14c34b2 into master Apr 25, 2021
@neufeldtech neufeldtech deleted the parallel-calls-ii branch April 25, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjavier2k mjavier2k mjavier2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallel Calls to SF API with GoRoutines
2 participants
@neufeldtech @mjavier2k