Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(license-plugin): Add support for leading NULL character #374

Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix(license-plugin): Add support for leading NULL character #374

merged 1 commit into from
Jun 4, 2019

Conversation

GerkinDev
Copy link
Contributor

@GerkinDev GerkinDev commented Jun 3, 2019

NULL characters are typically added by internal or virtual modules, but it sometimes corresponds to
a real file/module. The plugin should try to access the real package.json, if any

fix #1

PS: Sorry for the delay, I was sick the last few days. Here it is, tests included.

🍻 cheers !

NULL characters are typically added by internal or virtual modules, but it sometimes corresponds to
a real file/module. The plugin should try to access the real `package.json`, if any

fix #1
@mjeanroy mjeanroy merged commit 03c7eef into mjeanroy:master Jun 4, 2019
@mjeanroy
Copy link
Owner

mjeanroy commented Jun 4, 2019

@GerkinDev Awesome, thank you!!
Version 0.9.0 has just been published with your fix ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'package.json'
2 participants