Skip to content

Commit

Permalink
[WPT] link rel=preload with various errors/non-errors
Browse files Browse the repository at this point in the history 
Regression test for

- whatwg/html#7799
- https://crbug.com/1305317

Bug: 1305317, 1318623, 1318614, 1318618
Change-Id: I41218dec0f96c201135394dc483a6fa6fa12b7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3555471
Reviewed-by: Domenic Denicola <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#995963}
NOKEYCHECK=True
GitOrigin-RevId: 043561987bc6d8236a74b7a7131b186e088dd565
  • Loading branch information
@hiroshige-g @copybara-github
hiroshige-g authored and copybara-github committed Apr 26, 2022
1 parent 85469e3 commit 8931754
Show file tree
Hide file tree
Showing 2 changed files with 295 additions and 0 deletions.
72 changes: 72 additions & 0 deletions blink/web_tests/external/wpt/preload/preload-error.sub-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
This is a testharness.js-based test.
Found 68 tests; 59 PASS, 9 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS success (image): preload events
PASS success (image): main
PASS 404 (image): preload events
PASS 404 (image): main
PASS CORS (image): preload events
PASS CORS (image): main
PASS CORS-error (image): preload events
PASS CORS-error (image): main
PASS CSP-error (image): preload events
PASS CSP-error (image): main
PASS success (style): preload events
PASS success (style): main
FAIL 404 (style): preload events assert_unreached: preload onerror Reached unreachable code
PASS 404 (style): main
PASS CORS (style): preload events
PASS CORS (style): main
PASS CORS-error (style): preload events
PASS CORS-error (style): main
PASS CSP-error (style): preload events
PASS CSP-error (style): main
PASS success (script): preload events
PASS success (script): main
FAIL 404 (script): preload events assert_unreached: preload onerror Reached unreachable code
PASS 404 (script): main
PASS CORS (script): preload events
PASS CORS (script): main
PASS CORS-error (script): preload events
PASS CORS-error (script): main
PASS CSP-error (script): preload events
PASS CSP-error (script): main
PASS success (xhr): preload events
PASS success (xhr): main
FAIL 404 (xhr): preload events assert_unreached: preload onerror Reached unreachable code
FAIL 404 (xhr): main assert_unreached: XHR onabort Reached unreachable code
PASS CORS (xhr): preload events
PASS CORS (xhr): main
PASS CORS-error (xhr): preload events
PASS CORS-error (xhr): main
PASS CSP-error (xhr): preload events
PASS CSP-error (xhr): main
PASS success (fetch): preload events
PASS success (fetch): main
FAIL 404 (fetch): preload events assert_unreached: preload onerror Reached unreachable code
FAIL 404 (fetch): main assert_unreached: fetch() completed but text() timeout Reached unreachable code
PASS CORS (fetch): preload events
PASS CORS (fetch): main
PASS CORS-error (fetch): preload events
PASS CORS-error (fetch): main
PASS CSP-error (fetch): preload events
PASS CSP-error (fetch): main
FAIL Decode-error (image): preload events assert_unreached: preload onerror Reached unreachable code
PASS Decode-error (image): main
PASS Decode-error (style): preload events
PASS Decode-error (style): main
PASS Decode-error (script): preload events
PASS Decode-error (script): main
PASS MIME-error (image): preload events
PASS MIME-error (image): main
PASS MIME-error (script): preload events
PASS MIME-error (script): main
PASS MIME-error (style): preload events
FAIL MIME-error (style): main assert_unreached: Should have rejected: undefined Reached unreachable code
FAIL MIME-blocked (script): preload events assert_unreached: preload onload Reached unreachable code
PASS MIME-blocked (script): main
PASS MIME-blocked-nosniff (style): preload events
PASS MIME-blocked-nosniff (style): main
PASS MIME-blocked-nosniff (script): preload events
PASS MIME-blocked-nosniff (script): main
Harness: the test ran to completion.

223 changes: 223 additions & 0 deletions blink/web_tests/external/wpt/preload/preload-error.sub.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,223 @@
<!DOCTYPE html>
<meta charset="utf-8">
<head>
<title>link rel=preload with various errors/non-errors</title>
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/preload_helper.js"></script>
<meta http-equiv="Content-Security-Policy"
content="default-src 'self' http://{{hosts[alt][]}}:{{ports[http][0]}} 'unsafe-inline'">
<script>
// For various error/non-error network responses,, this test checks
// - load/error events fired on <link rel=preload>,
// - load/error events on main requests (e.g. <img>), and
// - preloads are reused for main requests
// (by verifyNumberOfResourceTimingEntries()).
//
// While this test expects <link rel=preload> error events only for network errors
// as specified in
// https://html.spec.whatwg.org/multipage/links.html#link-type-preload:fetch-and-process-the-linked-resource
// https://github.com/whatwg/html/pull/7799
// the actual browsers' behavior is different, and the feasibility of changing
// the behavior has not yet been investigated.
// https://github.com/whatwg/html/issues/1142.

setup({allow_uncaught_exception: true});

function preload(t, as, url, shouldPreloadSucceed) {
return new Promise(resolve => {
const link = document.createElement('link');
link.setAttribute('rel', 'preload');
link.setAttribute('as', as);
link.setAttribute('crossorigin', 'anonymous');
link.setAttribute('href', url);
link.onload = t.step_func_done(() => {
resolve();
if (!shouldPreloadSucceed) {
assert_unreached('preload onload');
}
});
link.onerror = t.step_func_done(() => {
resolve();
if (shouldPreloadSucceed) {
assert_unreached('preload onerror');
}
});
document.head.appendChild(link);
});
}

function runTest(api, as, description, shouldPreloadSucceed, shouldMainLoadSucceed,
urlWithoutLabel) {
description += ' (' + api + ')';

const url = new URL(urlWithoutLabel, location.href);
url.searchParams.set('label', api);

const tPreload = async_test(description + ': preload events');

promise_test(async t => {
let messageOnTimeout = 'timeout';
t.step_timeout(() => t.unreached_func(messageOnTimeout)(), 3000);

const preloadPromise = preload(tPreload, as, url, shouldPreloadSucceed);

// The main request is started just after preloading is started and thus
// HTTP response headers and errors are not observed yet.
let mainPromise;
if (api === 'image') {
mainPromise = new Promise(t.step_func((resolve, reject) => {
const img = document.createElement('img');
img.src = url;
img.setAttribute('crossorigin', 'anonymous');
img.onload = resolve;
img.onerror = () => reject(new TypeError('img onerror'));
document.head.appendChild(img);
}));
} else if (api === 'style') {
mainPromise = new Promise(t.step_func((resolve, reject) => {
const link = document.createElement('link');
link.href = url;
link.setAttribute('rel', 'stylesheet');
link.setAttribute('crossorigin', 'anonymous');
link.onload = resolve;
link.onerror = () => reject(new TypeError('link rel=stylesheet onerror'));
document.head.appendChild(link);
}));
} else if (api === 'script') {
mainPromise = new Promise(t.step_func((resolve, reject) => {
const script = document.createElement('script');
script.src = url;
script.setAttribute('crossorigin', 'anonymous');
script.onload = resolve;
script.onerror = () => reject(new TypeError('script onerror'));
document.head.appendChild(script);
}));
} else if (api === 'xhr') {
mainPromise = new Promise(t.step_func((resolve, reject) => {
const xhr = new XMLHttpRequest();
xhr.open('GET', url, true);
xhr.onload = resolve;
xhr.onerror = () => reject(new TypeError('XHR onerror'));
xhr.onabort = t.unreached_func('XHR onabort');
xhr.send();
}));
} else if (api === 'fetch') {
mainPromise = fetch(url)
.then(r => {
messageOnTimeout = 'fetch() completed but text() timeout';
return r.text();
});
} else {
throw new Error('Unexpected api: ' + api);
}

if (shouldMainLoadSucceed) {
await mainPromise;
} else {
await promise_rejects_js(t, TypeError, mainPromise);
}

// Wait also for <link rel=preload> events.
// This deflakes `verifyNumberOfResourceTimingEntries` results.
await preloadPromise;

verifyNumberOfResourceTimingEntries(url, 1);
}, description + ': main');
}

const tests = {
'image': {
url: '/preload/resources/square.png',
as: 'image',
mainLoadWillFailIf404Returned: false
},
'style': {
url: '/preload/resources/dummy.css',
as: 'style',

// https://html.spec.whatwg.org/multipage/semantics.html#default-fetch-and-process-the-linked-resource
mainLoadWillFailIf404Returned: true
},
'script': {
url: '/preload/resources/dummy.js',
as: 'script',

// https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-script
mainLoadWillFailIf404Returned: true
},
'xhr': {
url: '/preload/resources/dummy.xml',
as: 'fetch',
mainLoadWillFailIf404Returned: false
},
'fetch': {
url: '/preload/resources/dummy.xml',
as: 'fetch',
mainLoadWillFailIf404Returned: false
}
};

for (const api in tests) {
const url = tests[api].url;
const as = tests[api].as;

// Successful response.
runTest(api, as, 'success', true, true, url);

// Successful response: non-ok status is not considered as a network error,
// but can fire error events on main requests.
runTest(api, as, '404', true, !tests[api].mainLoadWillFailIf404Returned,
url + '?pipe=status(404)');

// Successful response: Successful CORS check.
runTest(api, as, 'CORS', true, true,
'http://{{hosts[alt][]}}:{{ports[http][0]}}' + url +
'?pipe=header(Access-Control-Allow-Origin,*)');

// A network error: Failed CORS check.
runTest(api, as, 'CORS-error', false, false,
'http://{{hosts[alt][]}}:{{ports[http][0]}}' + url);

// A network error: Failed CSP check on redirect.
runTest(api, as, 'CSP-error', false, false,
'/common/redirect.py?location=http://{{hosts[alt][]}}:{{ports[http][1]}}' +
url + '?pipe=header(Access-Control-Allow-Origin,*)');
}

// --------------------------------
// Content error.

// Successful response with corrupted image data.
// Not a network error, but can fire error events for images:
// https://html.spec.whatwg.org/multipage/images.html#update-the-image-data
runTest('image', 'image', 'Decode-error', true, false,
'/preload/resources/dummy.css?pipe=header(Content-Type,image/png)');
runTest('style', 'style', 'Decode-error', true, true,
'/preload/resources/dummy.xml?pipe=header(Content-Type,text/css)');
runTest('script', 'script', 'Decode-error', true, true,
'/preload/resources/dummy.xml?pipe=header(Content-Type,text/javascript)');

// --------------------------------
// MIME Type error.
// Some MIME type mismatches are not network errors.
runTest('image', 'image', 'MIME-error', true, true,
'/preload/resources/square.png?pipe=header(Content-Type,text/notimage)');
runTest('script', 'script', 'MIME-error', true, true,
'/preload/resources/dummy.css?pipe=header(Content-Type,text/notjavascript)');
// But they fire error events for <link rel=stylesheet>s.
// https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet:process-the-linked-resource
runTest('style', 'style', 'MIME-error', true, false,
'/preload/resources/dummy.js?pipe=header(Content-Type,not/css)');

// Other MIME type mismatches are network errors, due to:
// https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-mime-type?
runTest('script', 'script', 'MIME-blocked', false, false,
'/preload/resources/dummy.css?pipe=header(Content-Type,image/not-javascript)');
// https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-nosniff?
runTest('style', 'style', 'MIME-blocked-nosniff', false, false,
'/preload/resources/dummy.js?pipe=header(Content-Type,not/css)|header(X-Content-Type-Options|nosniff)');
runTest('script', 'script', 'MIME-blocked-nosniff', false, false,
'/preload/resources/dummy.css?pipe=header(Content-Type,text/notjavascript)|header(X-Content-Type-Options|nosniff)');
</script>

0 comments on commit 8931754

Please sign in to comment.