Transform static image references into externals #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When left intact, react-native's static image references, e.g.
require('image!fooBar')
, are problematic. By default, webpack attempts to resolve a loader called webpack-image-loader (plus many derivative names) and to resolve a module ('fooBar') based on the string after the bang. This yields compile errors, in my experience.So, seems these references need to be short-circuited. This PR does that by generating corresponding externals:
I believe this resolves #6 assuming @boyswan and I were seeing the same thing.