Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include base classes in output #108

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Include base classes in output #108

merged 1 commit into from
Jul 1, 2021

Conversation

bkoropoff
Copy link
Contributor

Part of resolving mkdocstrings/mkdocstrings#269

@bkoropoff bkoropoff mentioned this pull request Jun 19, 2021
Merged
pawamoy
pawamoy approved these changes Jun 27, 2021
View reviewed changes
Copy link
Member

@pawamoy pawamoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, simple and efficient. Thanks!

@pawamoy
Copy link
Member

pawamoy commented Jun 27, 2021 •
edited
Loading

I wonder: every class always depend on object right? Will object show up for every class' bases?
EDIT: Just tried, no, only for classes that inherit from no other classes 👍

@bkoropoff
Copy link
Contributor Author

__bases__ includes only direct base classes, so only object will only show up for classes that inherit directly from it with no intermediaries

@bkoropoff
Copy link
Contributor Author

I pushed a fix for a type check failure. There's also one in docs/macros.py that seems to pre-existing.

@pawamoy
Copy link
Member

pawamoy commented Jun 27, 2021

Yes, perfect, thanks, leave the one in the docs, I'll take care of it.

pawamoy
pawamoy reviewed Jun 27, 2021
View reviewed changes
src/pytkdocs/objects.py Outdated Show resolved Hide resolved
@bkoropoff
Copy link
Contributor Author

Is this ready to merge @pawamoy ?

@pawamoy pawamoy merged commit f7f6652 into mkdocstrings:master Jul 1, 2021
@pawamoy
Copy link
Member

pawamoy commented Jul 1, 2021

Thanks again @bkoropoff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkoropoff @pawamoy