Initial fix to switch order of preference for using docstring annotat… #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions over signature annotations in the 'docstring_sections' value of the output
ghandic
changed the title
pawamoy
requested changes
Sep 10, 2021
|
Thanks! I just added two comments. |
…docstring annotation
|
Thanks for the review, I think I have fixed the issues you've pointed out. If not then I think it might be worth adding some extra test cases of examples where it could break |
|
Great, thanks! The comments are especially appreciated! I'll run this locally to see how it behaves, and we should be good to go. |
|
Are there any fixes needed here? Or gtg? |
|
Hey @ghandic, thank you again, I'll merge this and release it in version 0.12.0 🙂 |
pawamoy
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial fix to switch order of preference for using docstring annotations over signature annotations in the 'docstring_sections' value of the output