Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotations parsing errors #96

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Fix annotations parsing errors #96

merged 1 commit into from
Feb 27, 2021

Conversation

pawamoy
Copy link
Member

@pawamoy pawamoy commented Feb 27, 2021

Issue #92

@pawamoy pawamoy marked this pull request as draft February 27, 2021 10:54
pawamoy added a commit that referenced this pull request Feb 27, 2021
@pawamoy
fix: Fix type annotations parsing
bfe48bd 
Instead of writing our own function,
we rely on `ast.unparse` on Python 3.9,
and on `astunparse.unparse` on previous Python versions.

Issue 92: #92
PR 96: #96
@pawamoy pawamoy force-pushed the fix-attr-parsing-py39 branch from 23b1b52 to bfe48bd Compare February 27, 2021 22:17
pawamoy added a commit that referenced this pull request Feb 27, 2021
@pawamoy
fix: Fix type annotations parsing
18b9626 
Instead of writing our own function,
we rely on `ast.unparse` on Python 3.9,
and on `astunparse.unparse` on previous Python versions.

Issue 92: #92
PR 96: #96
@pawamoy pawamoy force-pushed the fix-attr-parsing-py39 branch from bfe48bd to 18b9626 Compare February 27, 2021 22:58
@pawamoy pawamoy marked this pull request as ready for review February 27, 2021 22:59
@pawamoy
fix: Fix type annotations parsing
9025438 
Instead of writing our own function,
we rely on `ast.unparse` on Python 3.9,
and on `astunparse.unparse` on previous Python versions.

Issue 92: #92
PR 96: #96
@pawamoy pawamoy force-pushed the fix-attr-parsing-py39 branch from 18b9626 to 9025438 Compare February 27, 2021 23:00
@pawamoy pawamoy merged commit 68ac803 into master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pawamoy