Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): download video formats #369

Merged
merged 1 commit into from
Mar 2, 2025
Merged

fix(api): download video formats #369

merged 1 commit into from
Mar 2, 2025

Conversation

mkeithX
Copy link
Owner

@mkeithX mkeithX commented Mar 1, 2025

Motivation

This PR fixes incorrect video format selection in ytdl by using FFmpeg to ensure the right format matches the requested quality and options.

Checklist

  • I have read the Contributing Guidelines on Pull Request.
  • I have tested the changes locally.
  • I have ensured that all existing tests pass.
  • I have added necessary documentation (if applicable).

@mkeithX mkeithX added bug Something isn't working pr: internal Internal pull request labels Mar 1, 2025
@mkeithX mkeithX added this to the Planned milestone Mar 1, 2025
@mkeithX mkeithX merged commit 491e2c6 into main Mar 2, 2025
8 checks passed
@mkeithX mkeithX deleted the fix(api)-download-video-formats branch March 2, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working pr: internal Internal pull request
Projects
None yet
Milestone
Planned
Development

Successfully merging this pull request may close these issues.
1 participant
@mkeithX