Skip to content

Commit

Permalink
Updates the plugin to make it work with videojs 7. (#10)
Browse files Browse the repository at this point in the history
* Updates the plugin to make it work with videojs 7.

* Adds an example page.

Stores the player object since due to some reason the  call to `this.player()` returns undefined the second time it is called on the close function.

* Adds a parameter to disable or enable the socials filtering due to the mobile device check.

* Fixes husky warnings.

* Upgrades videojs version on package.json and on travis config file.

* Updates videojs dependency so that it acepts either ^6 || ^7.

* Bumps up the plugin version.

Since this not working anymore with versions 5 and under the version has been numped up to indicate breaking changes.
  • Loading branch information
OliDM authored and avdeev committed Aug 21, 2018
1 parent d6715e0 commit fb04cff
Show file tree
Hide file tree
Showing 9 changed files with 1,431 additions and 1,399 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ before_script:
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
env:
- VJS=5
- VJS=6
- VJS=7
addons:
firefox: latest
apt:
Expand Down
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ Copying to clipboard is done via [clipboard.js][clipboardjs].

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
## Installation
- [Version Support](#version-support)

- [Version Support](#version-support)
- [Installation](#installation)
- [Usage](#usage)
- [`<script>` Tag](#script-tag)
Expand All @@ -27,6 +28,10 @@ Copying to clipboard is done via [clipboard.js][clipboardjs].
- [Plugin initialization](#plugin-initialization)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->
## Version Support

This is an advanced plugin and due to that it works on videojs versions 6+ [see here](https://blog.videojs.com/feature-spotlight-advanced-plugins/).

## Installation

```sh
Expand Down Expand Up @@ -85,7 +90,7 @@ var shareOptions = {
image: 'https://dummyimage.com/1200x630',

// required for Facebook and Messenger
fbAppId: '12345',
fbAppId: '12345',
// optional for Facebook
redirectUri: window.location.href + '#close',

Expand Down
Loading

0 comments on commit fb04cff

Please sign in to comment.