Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vjs-share is applied to the entire player #12

Closed
Discookie opened this issue Sep 15, 2018 · 2 comments
Closed

.vjs-share is applied to the entire player #12

Discookie opened this issue Sep 15, 2018 · 2 comments

Comments

@Discookie
Copy link

Discussed further in iv-org/invidious#160.

Fanboy's Social Blocking and Fanboy's Annoyance List block the class .vjs-share.

This class is applied to the entire video frame here, along with .vjs-videojs-share:

this.player.ready(() => {
this.player.addClass('vjs-share');
player.addClass('vjs-videojs-share');
player.getChild('controlBar').addChild('ShareButton', options);
player.addChild('ShareOverlay', options);
});

But later you only make use of .vjs-videojs-share on the frame, while using .vjs-share for the button.

And thus the entire player is blocked, instead of only the share button.

@avdeev
Copy link
Collaborator

avdeev commented Nov 9, 2018

@Discookie @AlertDOTEXE PR welcome :)

@omarroth
Copy link
Contributor

Appears to be fixed using the latest version of Fanboy's Social Blocking and Fanboy's Annoyance List. Both now contain this line:

/videojs-share.

Which blocks assets for this plugin, so the player still works as normal. I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants