Add 'email' to socials #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omarroth Thanks! I think we can add a |
|
@omarroth Could you test this in the master branch? And I'll publish a release in NPM. |
|
Built from master, appears to work as expected 👍 |
|
@omarroth I've published v3.2.0 to NPM. You can switch to registry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanilla-sharing has an
emailoption that doesn't appear to be supported by this plugin.This is a first pass at adding support. It uses the same icon and colors as
mail.email.svgis currently a copy ofmail.svg, since I was unfortunately not able to make it work without having a second file with the name of the social.Also may make sense to add
subjecttosocialOptions(), although I'm not sure how that should be handled.