Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to support .md files #9

Merged
merged 15 commits into from
Sep 24, 2021
Merged

Conversation

suhhee1011
Copy link
Contributor

@suhhee1011 suhhee1011 commented Sep 23, 2021

This pull request resolves #9 . I added a feature to support markdown. Please, let me know by comment if it needs some more features to add or codes need to be fixed.

What I changed:

In generateHTMLStr function,

  1. Added regular expression to convert markdown files to HTML files
    • Find bold, italic, anchor, h1, and h2 tags
  2. Add conditions to distinguish if it is txt files or MD files
    • Convert bold, italic, anchor, h1, and h2 tags

In strToFile function,

  1. Added to let users can convert MD files to HTML.
  2. Both MD files and MD files with a folder can convert to HTML

@suhhee1011 suhhee1011 closed this Sep 23, 2021
@suhhee1011 suhhee1011 mentioned this pull request Sep 24, 2021
@mkim219 mkim219 reopened this Sep 24, 2021
@mkim219
Copy link
Owner

mkim219 commented Sep 24, 2021

I have reviewed your PR. There are a few things need to be changed:

  • The dist folder should be created in main directory, not the folder that contains md and txt files
  • There are unnecessary file you have committed. Please add those files in .gitignore and delete the files on your branch

@suhhee1011
Copy link
Contributor Author

Thank you for your comment. Based on your comment, I fixed the following:

  • Create a dist folder to the main directory instead of inside the text folder. Applied both file type text and MD.
  • Added .gitignore and add bin and obj to remove the unnecessary files

@mkim219
Copy link
Owner

mkim219 commented Sep 24, 2021

Thank you for your work! LGTM

@mkim219 mkim219 merged commit 9e7a966 into mkim219:main Sep 24, 2021
@suhhee1011 suhhee1011 mentioned this pull request Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants