use copy2 to preserve artifact timestamps, etc. #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, |
mkorpela
approved these changes
Dec 30, 2022
|
Got the merge done. Unfortunately GH PR did not work... so the change is in main but the PR closed. |
|
Thanks for the review, merge, and swift release... and of course for |
|
@bollwyvl swiftiness was not very good this time. Sorry - I’ve been busy with other stuff |
|
No snark meant at all! I only meant to suggest the transition from "merged" to "released" was quick, and I certainly wouldn't suggest time-to-review as a negative in this trivial little case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for pabot!
This proposes replacing
shutil.copyfilewithshutil.copy2to preserve artifact metadata like times when merged.No hardship if this is not desired, but seemed easier to just PR than have a big discussion about not wanting it.