BIO memory leak with pkey_from_pem and x509__x509_from_string?

[raybondo]

It looks like pkey_from_pem and x509__x509_from_string don't BIO_free their memory object when they succeed, only when they fail. Would this result in a memory leak? Or do the pkey and x509 cert objects retain a reference to the allocated memory and free it when they are freed?

[palmerabollo]

@raybondo did you find any fix or workaround for this issue?
There is a fix #43 , it would be great to merge it.

[raybondo]

Ah, thanks. I had added the BIO_free(mem); call to the two functions in our codebase. The fix #43 is identical to our internal change for x509__x509_from_string.

The pkey_from_pem leak still exists in the github version.

[palmerabollo]

Thanks for your quick answer. What do you mean by "our codebase"? Do you have a fork where the issue is fixed? I'd be happy to use it if possible.

[raybondo]

We have a private git repository that I pulled the luacrypto library into. Our repo is not publicly hosted and contains other libraries as well, so there's no actual fork that you could pull from, sorry. I know, we don't use github properly.

…

On Mon, Oct 30, 2017 at 3:27 PM, Guido García ***@***.***> wrote: Thanks for your quick answer. What do you mean by "our codebase"? Do you have a fork where the issue is fixed? I'd be happy to use it if possible. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAN-g6CWULHkYSfX8VEQtFm4L74a2xXks5sxjFFgaJpZM4Jjcye> .