Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nixos module #15

Merged
merged 15 commits into from
Nov 7, 2022
Merged

add nixos module #15

merged 15 commits into from
Nov 7, 2022

Conversation

brainrake
Copy link

@brainrake brainrake commented Aug 2, 2022 •
edited
Loading 

nix run '.#vm'

@brainrake brainrake force-pushed the marton/nixos-module branch 4 times, most recently from 755df1b to 8e01927 Compare August 8, 2022 11:12
ngua
ngua reviewed Sep 29, 2022
View reviewed changes
Copy link

@ngua ngua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module itself looks fine. The only thing would be to fix the merge conflicts (I had to merge the v5.5 branch into staging, otherwise we'd have the wrong version of Ogmios)

flake.nix Outdated Show resolved Hide resolved
@brainrake brainrake force-pushed the marton/nixos-module branch from e698082 to 35cd4d3 Compare October 3, 2022 19:06
@brainrake brainrake force-pushed the marton/nixos-module branch from 35cd4d3 to 8122c9d Compare October 3, 2022 19:09
@brainrake
Copy link
Author

Thanks for the review! Updated.

aciceri
aciceri reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@aciceri aciceri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also add something in README?

flake.nix Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
nix/ogmios-nixos-module.nix Outdated Show resolved Hide resolved
nix/ogmios-nixos-module.nix Outdated Show resolved Hide resolved
nix/ogmios-nixos-module.nix Outdated Show resolved Hide resolved
@brainrake
Copy link
Author

added an issue for docs
#19

@brainrake brainrake requested a review from t4ccer November 4, 2022 12:01
@brainrake brainrake merged commit c1abe7a into staging Nov 7, 2022
@brainrake brainrake deleted the marton/nixos-module branch November 7, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngua ngua ngua left review comments

@aciceri aciceri aciceri left review comments

@t4ccer t4ccer Awaiting requested review from t4ccer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brainrake @aciceri @ngua