Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade base torchio version #749

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Upgrade base torchio version #749

merged 7 commits into from
Nov 28, 2023

Conversation

scap3yvt
Copy link
Collaborator

Fixes #N.A.

Proposed Changes

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

Copy link
Contributor

github-actions bot commented Nov 27, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@scap3yvt scap3yvt requested a review from sarthakpati November 27, 2023 16:43
sarthakpati
sarthakpati previously approved these changes Nov 27, 2023
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

auto-merge was automatically disabled November 27, 2023 20:24

Pull Request is not mergeable

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6a73fb) 94.67% compared to head (020a6f7) 94.68%.
Report is 3 commits behind head on master.

❗ Current head 020a6f7 differs from pull request most recent head 5a3cbc1. Consider uploading reports for the commit 5a3cbc1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   94.67%   94.68%   +0.01%     
==========================================
  Files         117      117              
  Lines        8242     8242              
==========================================
+ Hits         7803     7804       +1     
+ Misses        439      438       -1     
Flag Coverage Δ
unittests 94.68% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarthakpati
Copy link
Collaborator

sarthakpati commented Nov 27, 2023

hey @hasan7n @aristizabal95 - do you know why the git error is coming for the MLCube test?

/usr/bin/git rev-parse --show-toplevel
/home/runner/work/GaNDLF/GaNDLF
/usr/bin/git diff --diff-filter=D --name-only b5a41c946775e89f9b2266bcb8f5d58e4dc45d48...845c91e61701591ee438cfe05d79bcd8f7523134
fatal: b5a41c946775e89f9b2266bcb8f5d58e4dc45d48...845c91e61701591ee438cfe05d79bcd8f7523134: no merge base
Error: The process '/usr/bin/git' failed with exit code 128

@aristizabal95
Copy link
Contributor

@sarthakpati I couldn't find any commit with hash 845c91e61701591ee438cfe05d79bcd8f7523134 anywhere. I have no idea why that action is using that non-existent hash and where it comes from. At least from the workflow file I can't find a way we could be passing wrong information to the action, so this most probably means a bug in the action code itself?

@sarthakpati
Copy link
Collaborator

sarthakpati commented Nov 28, 2023

@sarthakpati I couldn't find any commit with hash 845c91e61701591ee438cfe05d79bcd8f7523134 anywhere. I have no idea why that action is using that non-existent hash and where it comes from. At least from the workflow file I can't find a way we could be passing wrong information to the action, so this most probably means a bug in the action code itself?

Oh okay. What would be the solution for this, then?

UPDATE: I guess pushing a new hash just worked 🙄

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@sarthakpati sarthakpati merged commit 941532b into master Nov 28, 2023
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
@sarthakpati sarthakpati deleted the scap3yvt-patch-2 branch November 28, 2023 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants