Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidated a few checks #774

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Consolidated a few checks #774

merged 1 commit into from
Jan 17, 2024

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Jan 17, 2024 •
edited by sarthakpati
Loading

Fixes #N.A.

Proposed Changes

  • improving code readability

Checklist

  • I have read the CONTRIBUTING guide.
  • My PR is based from the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated.
  • Code has been blacked for style consistency.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].

@scap3yvt scap3yvt requested a review from sarthakpati January 17, 2024 14:16
@github-actions GitHub Actions
Copy link
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

sarthakpati
sarthakpati approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarthakpati sarthakpati enabled auto-merge January 17, 2024 14:18
@sarthakpati sarthakpati merged commit ddf8fb9 into master Jan 17, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
@sarthakpati sarthakpati deleted the scap3yvt-patch-2 branch January 17, 2024 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sarthakpati sarthakpati sarthakpati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scap3yvt @sarthakpati