Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new optimizers #970

Merged
merged 18 commits into from
Nov 21, 2024

Conversation

scap3yvt
Copy link
Collaborator

Fixes #968

Proposed Changes

  • added the lion and adopt optimizers
  • added documentation about how to include thirdparty optimizers (where the code is available but in different repositories)

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner November 20, 2024 16:35
@scap3yvt scap3yvt marked this pull request as draft November 20, 2024 16:36
Copy link
Contributor

github-actions bot commented Nov 20, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@scap3yvt
Copy link
Collaborator Author

Adopt needs updated PyTorch, so I have put a new PR for that.

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions regarding the wording.

GANDLF/optimizers/README.md Outdated Show resolved Hide resolved
@sarthakpati sarthakpati marked this pull request as ready for review November 21, 2024 15:18
@sarthakpati sarthakpati merged commit 966f84f into mlcommons:master Nov 21, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add new optimizers
2 participants