Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A precheck function in customize.py #357

Closed
arjunsuresh opened this issue Jul 19, 2024 · 0 comments
Closed

A precheck function in customize.py #357

arjunsuresh opened this issue Jul 19, 2024 · 0 comments
Assignees
@arjunsuresh
Labels
enhancement New feature or request

Comments

@arjunsuresh
Copy link
Contributor

We do have cases where we want to turn on some dependencies based on some input validation. For example, if a model path is given and we might want to validate the presence of model (say using md5sum check) and only if it fails turn on the model download dependency. Currently this is possible via doing the check in preprocess function and doing the download as a prehook dependency. It'll be a cleaner approach if we can do this check in a precheck function and use normal dependencies instead of prehook dependencies.
@arjunsuresh arjunsuresh added the enhancement New feature or request label Jul 19, 2024
@arjunsuresh arjunsuresh self-assigned this Jul 19, 2024
@arjunsuresh arjunsuresh transferred this issue from mlcommons/cm4mlops Jul 23, 2024
@arjunsuresh arjunsuresh transferred this issue from mlcommons/cm4mlperf-inference Oct 8, 2024
arjunsuresh added a commit that referenced this issue Nov 29, 2024
@arjunsuresh @mlcommons-bot
Added predeps function, removed unused dirs (#629)
4b83640 
* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes #357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

---------

Co-authored-by: mlcommons-bot <[email protected]>
arjunsuresh added a commit that referenced this issue Dec 1, 2024
@arjunsuresh @mlcommons-bot
Added pandas deps for sdxl reference implementation (#637)
841de10 
* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes #357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

* Added pandas deps for sdxl

---------

Co-authored-by: mlcommons-bot <[email protected]>
arjunsuresh added a commit that referenced this issue Dec 3, 2024
@arjunsuresh @mlcommons-bot
Added pandas requirement for MLPerf inference SDXL (#638)
7cf33a6 
* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes #357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

* Added pandas deps for sdxl

---------

Co-authored-by: mlcommons-bot <[email protected]>
arjunsuresh added a commit to mlcommons/mlperf-automations_archived that referenced this issue Dec 4, 2024
@arjunsuresh @mlcommons-bot
Added predeps function, removed unused dirs (mlcommons#629)
d25ff6b 
* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes mlcommons#357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

---------

Co-authored-by: mlcommons-bot <[email protected]>
Former-commit-id: 4ca0eb2
arjunsuresh added a commit to mlcommons/mlperf-automations_archived that referenced this issue Dec 4, 2024
@arjunsuresh
Sync Mlperf inference (mlcommons#630)
8655135 
* Support input conf_file for mlperf-power-server

* Support num_analyzers input

* Don't save console log for mlperf power, revisit later

* Update format.yml

* [Automated Commit] Format Codebase

* Added predeps function, removed unused dirs (mlcommons#629)

* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes mlcommons#357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

Former-commit-id: 3374925
arjunsuresh pushed a commit to mlcommons/mlperf-automations_archived that referenced this issue Dec 4, 2024
@anandhu-eng @arjunsuresh
Igbh dataset download script improvemenet (mlcommons#632)
0ac8867 
* changes for igbh dataset download

* changed logic precedence

* handle if env not in dependency

Former-commit-id: 69d670c

Added pandas deps for sdxl reference implementation  (mlcommons#637)

* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes mlcommons#357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

* Added pandas deps for sdxl

---------

Former-commit-id: f2e18e6
arjunsuresh added a commit to mlcommons/mlperf-automations_archived that referenced this issue Dec 4, 2024
@arjunsuresh
Added pandas requirement for MLPerf inference SDXL (mlcommons#638)
716fd7e 
* Delete tests directory

* Delete report directory

* Delete challenge directory

* Added predeps function, fixes mlcommons#357

* [Automated Commit] Format Codebase

* Update format.yml | Avoid formatting deleted files

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Added a meta option to turn off predeps

* [Automated Commit] Format Codebase

* Update README-extra.md

* Added pandas deps for sdxl

---------

Co-authored-by: mlcommons-bot <[email protected]>
Former-commit-id: 8b69f08

Update README.md

Former-commit-id: 8acaa22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunsuresh arjunsuresh

Labels
enhancement New feature or request
Projects
No open projects
CM as next generation of CK
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arjunsuresh