-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MLCube support for Object Detection Benchmark #501
base: master
Are you sure you want to change the base?
Add MLCube support for Object Detection Benchmark #501
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@mmarcinkiewicz are you the right person to review this one? |
object_detection/README.md
Outdated
|
||
```bash | ||
mlcube run ... -Pdocker.build_strategy=always | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the benchmark README template. So can you please add sections that have been moved to README.old back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks for pointing this out, move mlcube explanation into the mlcube folder
object_detection/download_dataset.sh
Outdated
curl -O http://images.cocodataset.org/zips/train2017.zip | ||
echo "Extracting train2017.zip:" | ||
n_files=`unzip -l train2017.zip| grep .jpg | wc -l` | ||
unzip train2017.zip | { I=-1; while read; do printf "Progress: $((++I*100/$n_files))%%\r"; done; echo ""; } | ||
|
||
# TBD: MD5 verification | ||
# $md5sum *.zip *.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a checksum verification step to make sure changes do not affect the dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, added the validation inside the download_dataset.sh file.
@@ -0,0 +1,5 @@ | |||
SAVE_CHECKPOINTS: "True" # Instead of False use empty value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SAVE_CHECKPOINTS should be False by default since that code path is not well tested in the recent past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please share a log from an end-to-end training run using mlcube so it can be compared to the previous workflow?
@davidjurado can you please address Shriya's feedback. We can then merge this PR. |
2c969eb
to
489ed0f
Compare
Benchmark execution with MLCube
Project setup
Dataset
The COCO dataset will be downloaded and extracted. Sizes of the dataset in each step:
Tasks execution
Parameters are defined at these files:
Demo execution
These tasks will use a demo dataset (39M) to execute a faster training workload for a quick demo (~12 min):
It's also possible to execute the two tasks in one single instruction:
Aditonal options
Parameters defined at mculbe/mlcube.yaml could be overridden using:
--param=input
We are targeting pull-type installation, so MLCube images should be available on docker hub. If not, try this: