Remove lxd support

Although lxd itself is still a viable, maintained platform (5.0 LTS was just released in April 2022), and has some advantages over using Docker, the support for lxd in tpaexec is unused and unmaintained. Since there hasn't been any perceptible interest in using it for a long time, we're better off removing the support until that changes. Closes #327
mlira59 · Apr 11, 2022 · 451150d · 451150d
1 parent 39a211d
commit 451150d
Show file tree

Hide file tree

Showing 15 changed files with 3 additions and 218 deletions.
diff --git a/.gitignore b/.gitignore
@@ -221,7 +221,6 @@ tpa-venv/*
 pip-packages/*
 .python-version
 platforms/aws/inventory/ec2.py
-platforms/lxd/inventory/lxd.py
 *tags*
 cscope*
 pdf/*

diff --git a/bin/tpaexec b/bin/tpaexec
@@ -162,7 +162,6 @@ _install_pip_packages() {
     declare -A contribs
     contribs=(
         [inventory/ec2.py]=platforms/aws
-        [inventory/lxd.py]=platforms/lxd
     )
     for f in "${!contribs[@]}"; do
         cp -v "$CONTRIB_DIR/$f" \

diff --git a/docs/src/platform-lxd.md b/docs/src/platform-lxd.md
diff --git a/docs/tpa.yml b/docs/tpa.yml
@@ -19,7 +19,6 @@ nav:
     - AWS: platform-aws.md
     - Bare metal: platform-bare.md
     - Docker: platform-docker.md
-    - LXD: platform-lxd.md
     - Vagrant: platform-vagrant.md
   - Customisations:
     - Cluster configuration: configure-cluster.md

diff --git a/lib/tpaexec/platform/__init__.py b/lib/tpaexec/platform/__init__.py
@@ -49,7 +49,7 @@ def all_platforms():
         """
         Returns a list of all platform names
         """
-        return ["aws", "bare", "docker", "lxd", "vagrant"]
+        return ["aws", "bare", "docker", "vagrant"]
 
     @property
     def default_volume_device_name(self):

diff --git a/lib/tpaexec/platform/lxd.py b/lib/tpaexec/platform/lxd.py
diff --git a/platforms/common/inventory/inventory.j2 b/platforms/common/inventory/inventory.j2
@@ -1,9 +1,7 @@
 {# © Copyright EnterpriseDB UK Limited 2015-2022 - All rights reserved. #}
 [{{ cluster_tag }}]
 {% for h in instance_vars %}
-{% if h.platform == 'lxd' %}
-{{ h.Name }} ansible_connection=lxd node={{ h.node }} platform={{ h.platform }}
-{% elif h.platform == 'docker' %}
+{% if h.platform == 'docker' %}
 {{ h.Name }} ansible_connection=docker node={{ h.node }} platform={{ h.platform }}
 {% else%}
 {{ h.Name }} ansible_host={{ h|deploy_ip_address }} node={{ h.node }} platform={{ h.platform }}

diff --git a/platforms/lxd/README.md b/platforms/lxd/README.md
diff --git a/platforms/lxd/_metadata b/platforms/lxd/_metadata
diff --git a/platforms/lxd/deprovision.yml b/platforms/lxd/deprovision.yml
diff --git a/platforms/lxd/inventory/lxd.ini.j2 b/platforms/lxd/inventory/lxd.ini.j2
diff --git a/platforms/lxd/inventory/write.yml b/platforms/lxd/inventory/write.yml
diff --git a/platforms/lxd/provision.yml b/platforms/lxd/provision.yml
diff --git a/platforms/lxd/validate.yml b/platforms/lxd/validate.yml
diff --git a/pyrightconfig.json b/pyrightconfig.json
@@ -7,8 +7,7 @@
     ],
     "exclude": [
         "tpa-venv",
-        "platforms/aws/inventory",
-        "platforms/lxd/inventory"
+        "platforms/aws/inventory"
     ],
     "venvPath": ".",
     "venv": "tpa-venv"