Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new idea for data transfer / feed metadata #110

Closed
wants to merge 2 commits into from

Conversation

paulpc
Copy link
Contributor

@paulpc paulpc commented Jan 8, 2015

This should work partially with the feeds I have in there. There is still quite a bit of messy code, so, obviously it's not ready for the prime time yet, but it's the accumulation of a few ideas discussed on the slack.com site.

I'll try to comment the code some more when I get some time in the next week or so

@krmaxwell
Copy link
Member

I pulled this into the paulpc-data branch and fixed some merge conflicts, but please rebase when you get a chance.

Also: is there any way we can avoid the from parsers import *? I realize you specified __all__ in __init__.py but I feel like we should avoid that for the purposes of readability and maintainability.

@paulpc
Copy link
Contributor Author

paulpc commented Jan 8, 2015

But that will take away from the cool factor and simplicity of adding
parsers. Currently all it takes is a the python file and an entry in the
config file - no additional code changes in the main files. I'll figure
something out.
On Jan 8, 2015 5:56 PM, "Kyle Maxwell" [email protected] wrote:

I pulled this into the paulpc-data branch and fixed some merge conflicts,
but please rebase when you get a chance.

Also: is there any way we can avoid the from parsers import *? I realize
you specified all in init.py but I feel like we should avoid that
for the purposes of readability and maintainability.


Reply to this email directly or view it on GitHub
#110 (comment).

@krmaxwell
Copy link
Member

I get what you're saying and that's attractive. But it feels very un-Pythonic to me. Curious what others think, of course. :)

@paulpc
Copy link
Contributor Author

paulpc commented Jan 9, 2015

I need to go see how mgoffin did it in CRITs - i thought that was pretty elegant

@alexcpsec alexcpsec mentioned this pull request Jan 9, 2015
@krmaxwell krmaxwell mentioned this pull request Jan 9, 2015
@alexcpsec
Copy link
Member

This is deprecated by #121. Thanks a lot for giving it a go @paulpc, and we really welcome your suggestions for what else we need there to get it good for v0.2.0

@alexcpsec alexcpsec closed this Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants